-
Notifications
You must be signed in to change notification settings - Fork 570
use custom prom/grafana images with shared provisioning #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidoots
reviewed
Sep 6, 2019
emidoots
reviewed
Sep 6, 2019
emidoots
reviewed
Sep 6, 2019
emidoots
reviewed
Sep 6, 2019
emidoots
reviewed
Sep 6, 2019
Member
emidoots
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really exciting! I'll test this once you address my comments
DaedalusG
added a commit
that referenced
this pull request
Jul 9, 2025
…ate main target bug (#1231) Closes REL-1067 ## Problem The release pipeline has been systematically failing in the `promoteToPublic.finalize` workflow with this error: ``` Warning: 1 uncommitted change must be on a branch named differently than 'promote/release-v6.4.3889-update-main' ``` ## Root Cause The final `github:pr` step in the `promoteToPublic.finalize` workflow was incorrectly trying to create a PR from the current branch to itself: - **Current branch**: `promote/release-{{version}}-update-main` - **Target branch**: `promote/release-{{version}}-update-main` ❌ (same branch!) - **Should target**: `main` ✅ This happened because the variable `internal_branch` was set to the current branch name instead of the intended target branch. ### Test plan This will have to be tested on a release <br> Backport d7ddf22 from #1227 Co-authored-by: Warren Gifford <warrenbruceg@gmail.com>
DaedalusG
added a commit
that referenced
this pull request
Aug 7, 2025
…amp registry (#1261) ## Problem The release creation process was failing with 404 errors when trying to fetch images like cadvisor:6.6.2517 from the legacy internal registry. ## Root Cause Recent changes in the main sourcegraph repo migrated from legacy registries to new 'revamp' registries, but the deploy repos were still hardcoded to use the old registry. ## Solution - Replace `us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal` with `us-docker.pkg.dev/sourcegraph-images/internal` - Updated both release.yaml and batch-change/release.yaml - Tested and confirmed images exist in the new registry ## Test Plan - Validated that cadvisor:6.6.2517 exists in new registry but not in old registry - Successfully tested sg ops update-images command with new registry - Confirmed this fixes the original 404 errors during release creation <br> Backport 5b81ee7 from #1260 Co-authored-by: Warren Gifford <warrenbruceg@gmail.com> Co-authored-by: Amp <amp@ampcode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
images defined in https://github.com/sourcegraph/sourcegraph/pull/5343