Skip to content

Conversation

@uwedeportivo
Copy link
Contributor

Copy link
Member

@emidoots emidoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really exciting! I'll test this once you address my comments

@uwedeportivo uwedeportivo merged commit fbb8335 into master Sep 9, 2019
@uwedeportivo uwedeportivo deleted the docker_prom branch September 9, 2019 05:53
DaedalusG added a commit that referenced this pull request Jul 9, 2025
…ate main target bug (#1231)

Closes REL-1067

## Problem

The release pipeline has been systematically failing in the
`promoteToPublic.finalize` workflow with this error:
```
Warning: 1 uncommitted change
must be on a branch named differently than 'promote/release-v6.4.3889-update-main'
```

## Root Cause

The final `github:pr` step in the `promoteToPublic.finalize` workflow
was incorrectly trying to create a PR from the current branch to itself:

- **Current branch**: `promote/release-{{version}}-update-main`
- **Target branch**: `promote/release-{{version}}-update-main` ❌ (same
branch!)
- **Should target**: `main` ✅

This happened because the variable `internal_branch` was set to the
current branch name instead of the intended target branch.

### Test plan
This will have to be tested on a release
 <br> Backport d7ddf22 from #1227

Co-authored-by: Warren Gifford <warrenbruceg@gmail.com>
DaedalusG added a commit that referenced this pull request Aug 7, 2025
…amp registry (#1261)

## Problem
The release creation process was failing with 404 errors when trying to
fetch images like cadvisor:6.6.2517 from the legacy internal registry.

## Root Cause
Recent changes in the main sourcegraph repo migrated from legacy
registries to new &#39;revamp&#39; registries, but the deploy repos were
still hardcoded to use the old registry.

## Solution
- Replace `us-central1-docker.pkg.dev/sourcegraph-ci/rfc795-internal`
with `us-docker.pkg.dev/sourcegraph-images/internal`
- Updated both release.yaml and batch-change/release.yaml
- Tested and confirmed images exist in the new registry

## Test Plan
- Validated that cadvisor:6.6.2517 exists in new registry but not in old
registry
- Successfully tested sg ops update-images command with new registry
- Confirmed this fixes the original 404 errors during release creation
<br> Backport 5b81ee7 from #1260

Co-authored-by: Warren Gifford <warrenbruceg@gmail.com>
Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants